Set Window icon on Windows #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loads and applies `kolibri.ico` to the main `wx.Frame`, replacing the default system icon in the title bar.
ozer550
approved these changes
Sep 1, 2025
Member
ozer550
left a comment
ozer550
left a comment
There was a problem hiding this comment.
I've verified the change and it works as expected!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The main application window was displaying the generic default system icon in its title bar.
This change ensures the Kolibri icon is loaded and set for the main window.
File Changed
src/kolibri_app/view.pyReferences
Not related to any issues or PR
Reviewer guidance
To test: download and run the installer created by Git Action:
Build Unsigned EXEVerify: the Kolibri icon should now appears in the top-left corner of the application window's title bar, replacing the old default icon.