Stop legacy cleanup from deleting new desktop shortcut #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The post-install script was deleting the `Kolibri.lnk` shortcut it had just created, assuming it was a leftover from a legacy installation. This commit comments out the legacy shortcut deletion code to ensure the icon persists as expected.
rtibbles
requested changes
Sep 5, 2025
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
I think per your note in the PR description - the issue here is that if we don't choose to create a desktop shortcut with the new installer, then the old desktop shortcut is left in place - which then doesn't point to the new Kolibri executable, which could be confusing for users. Can we conditionalize this cleanup based on whether or not the choice was chosen earlier in the installation?
Contributor
Author
|
So, if the user did not choose to create a destop icon, the code proceeds to find and delete the old Kolibri.lnk shortcut that was created in the previous installation, correct? |
Member
|
Correct! |
If the user performs an upgrade or repair and unchecks the "Create a desktop icon" option, the installer will now correctly remove any pre-existing desktop icon.
rtibbles
approved these changes
Sep 9, 2025
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
Changes make sense to me, manual testing checks out too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The post-install script was deleting the
Kolibri.lnkshortcut it had just created, assuming it was a leftover from a legacy installation.This change comments out the legacy shortcut deletion code to ensure the icon persists as expected.
References
Fixes issue introduced in PR #186
Reviewer guidance
Download and run the legacy kolibri installer from here.
Download and run the new installer created by Git Action: Build Unsigned EXE
Verify: After the installation of the new app the kolibri destop shortcut should be present on your desktop and it should opens kolibri as expected.
Note
Currently when the "Create a desktop shortcut" option is not checked during installation, but a destop shortcut is created from a previous installation it doesn't get deleted.
If you think it's better that we change that please let me know.