Skip to content

Conversation

@rtibbles
Copy link
Member

Starts the server inside the application process.
Defers only task workers to a foregrounded service.

@rtibbles rtibbles force-pushed the architecture_prototype branch 3 times, most recently from f58b353 to f67aa60 Compare May 12, 2022 16:07
from kolibri.utils.server import PID_FILE
from kolibri.utils.server import STATUS_RUNNING
from kolibri.utils.server import wait_for_status
from kolibri.utils.server import BaseKolibriProcessBus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail awkwardly if we're using Kolibri < 0.16. Should we add an extra check to the Makefile so this gets caught early?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do - we've mostly relied on tagging and versioning of the installer repos to keep that in check, but doesn't hurt to add extra.

At the very least, we can update the README.

@dylanmccall
Copy link
Contributor

This looks pretty good to me and I have a branch merging it with some of the stuff we've glued together downstream: endlessm#20. I also add a bit of refactoring, and my thought is I'll split that into a different pull request once we have this sorted out.

Using the newest build of Kolibri from the develop branch, the workers service seems to be doing its thing: worker-related stuff appears in logcat without any obvious errors. With that said, it does run into an error importing content, but I think that's just a problem in Kolibri, not here. (It gets a 404 requesting /device/api/device_channel/000409f81dbe5d1ba67101cb9fed4530/?include_fields=total_resources%2Ctotal_file_size%2Con_device_resources%2Con_device_file_size%2Cnew_resource_count%2Cnew_resource_total_size&1652997798744=1652997798744, and then throws an exception here: https://github.com/learningequality/kolibri/blob/1fd1fc08c92eae64634126a757c9e1af442870c2/kolibri/core/assets/src/api-resources/task.js#L14-L16).

@rtibbles
Copy link
Member Author

Oh yes, absolute latest develop is completely broken on the frontend for tasks - because of some of the Task API refactoring that I alluded to earlier. I am fixing it as we speak.

@rtibbles
Copy link
Member Author

Going to merge this for now, we can make more updates as we go.

@rtibbles rtibbles merged commit fb18a88 into develop May 19, 2022
@rtibbles rtibbles deleted the architecture_prototype branch May 19, 2022 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants