Proper cmdline-tools installation #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This installs cmdline-tools using sdkmanager itself, which has a few advantages: * You no longer need to specify `--sdk_root` since it will detect the SDK install path when it's installed correctly. * For a persistent installation, cmdline-tools can be updated and it will correctly replace the existing version. * p4a will now try using `avdmanager` from `cmdline-tools/latest/bin` before the deprecated `tools/bin`. That allows using Java 11 on the host rather than Java 8 since the newer `avdmanager` doesn't try to use the removed `javax.xml` classes. The downside is that cmdline-tools gets downloaded twice. I haven't seen a way to cleanly bootstrap the SDK from a single download.
The whole point of installing cmdline-tools is to get sdkmanager, so the recipe might as well specify that as the target. That way `make` can tell that it doesn't need to do that again if the target gets pulled in.
Member
|
Hi @dbnicholson - sorry, I totally missed this PR. I've merged the relevant P4A PR on our fork, can you update this one with this hash |
Contributor
Author
No problem. Updated now. |
rtibbles
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This installs cmdline-tools in the "proper" way using sdkmanager itself. Mostly this is just moving the deck chairs around, but it also enables building using Java 11 on the host after learningequality/python-for-android#3.