Tweak logging to avoid repeated logging calls. #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jredrejo
approved these changes
Sep 13, 2023
Member
jredrejo
left a comment
jredrejo
left a comment
There was a problem hiding this comment.
Right today I had read this article https://adamj.eu/tech/2023/09/07/introducing-flake8-logging/ , LOG001 is this case. I would not dislike adding this flake8 plugin to our code base
Member
Author
|
Yes, we should probably also be adding LOG-011 but I know that will require some cleanup as we have plenty of violations! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156
Which appears after closer examination of the logs to just be an issue with the root logger having an additional handler added to it after Kolibri has been initialized.
Solves this by using a named logger, and holding off on logging until after Kolibri has been initialized.