Skip to content

Conversation

@rtibbles
Copy link
Member

@rtibbles rtibbles commented Oct 4, 2023

  • Generates a dummy proquint user name for the on my own setup workflow
  • Registers the get_os_user capability to return this
  • Fixes oversight where Android API version had not been incremented in the Makefile for system setup

Fixes #133

image

Generate an auth token on each boot to verify access from the app.
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generates a dummy proquint user name for the on my own setup workflow

So it looks like we are checking in the [AppBar](https://github.com/learningequality/kolibri/blob/00010153e3c3329acb3540166819a1c68816d203/kolibri/core/assets/src/views/AppBar.vue#L128) for if the username is a proquint then? In a typical use where we actually get the OS user from the OS, we'll have their Full Name from there and will show that instead of the hashed username.

Curious how you got that username then to show up? Maybe that regex isn't checking for the proquint as I'm thinking?

@rtibbles
Copy link
Member Author

rtibbles commented Oct 4, 2023

Proquint values are alphabetic - not an alphanumeric hexadecimal, so they're not matched by that regex.

We don't have a full name here either, so having it try to display that wouldn't be helpful either!

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions answered - lgtm

@rtibbles rtibbles merged commit 29ed7c7 into develop Oct 4, 2023
@rtibbles rtibbles deleted the get_os_user branch October 4, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement get_os_user interface/capability

3 participants