Do not try to set tasks as expedited when Android does not allow it. #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nucleogenesis
approved these changes
Oct 13, 2023
Member
nucleogenesis
left a comment
nucleogenesis
left a comment
There was a problem hiding this comment.
Code change LGTM - comments are very clear. It's nice to have direct links to the platform source that just says "you can't do that".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
This fixes errors caused by the implementation of task scheduling via WorkManager. The documentation is not terribly clear on this point, but it seems that
setExpeditedcannot be called on either delayed tasks or periodic tasks.This PR prevents this happening in either case and adds explanatory comments so that we don't forget.