Dev Cache/Build Overhaul #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add notes
Added effect of improving Makefile for local dev. A more traitional build approach. No longer _has_ to bind mount, etc.
Using docker ADD to invalidate pip install cache, will update if downloaded zips have changed. Also setting up volumes to persist android downloads between builds.
Contributor
|
@DXCanas This looks awesome, thanks! Will give it a spin tomorrow and review! :) |
kollivier
reviewed
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rethinking how we cache things.
Have run into a few issues with cache being too aggressive, where dependency changes and pyeverywhere/python-for-android changes wouldn't propagate during build time in the pipeline.
Reworking the order of that. Changes for our vendored versions of those are now checked fore before installation so that cache invalidates on update.
android distro caches now happen inside of volumes and are mounted between builds, so those aren't invalidated unless we need different SDK/NDKs. Easy to delete, too:
docker volume rm <name of volume>And I de-prioritized source code reuse, as the source is actually really small. Meaning we can now deploy this image and have it run cache-less if we want, just as docker intended.