Set KOLIBRI_RUN_MODE based on signing key for APK (dev, testing, prod) #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Merging so we can get a final build for testing tomorrow, but post-hoc review still welcome. |
cyberorg
pushed a commit
to cyberorg/kolibri-installer-android
that referenced
this pull request
Aug 22, 2020
Set KOLIBRI_RUN_MODE based on signing key for APK (dev, testing, prod)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Slack -- it checks the org that signed the installed APK, and sets the run mode based on that. It distinguishes between dev/debug APKs (signed locally), regular production builds (signed by LE) and released builds (signed by Google via the Play Store).