Automatic content syncing: preferred instance tracking and fixes

[bjester]

Summary

Resolves issues with stalled 'My Downloads' through final integration of device settings features and usage of a reserved Network Location for Studio, allowing us to set a preference for which device to source downloads from.

Details

• Adds source_instance_id to ContentRequest model as the preferred instance to source the content from
• Updates ContentDownloadRequest API to support source_instance_id
• Adds validator to automatic content download task, aligned with whether or not it's enabled
• Adds tests for content_request utilities handling metadata import, peer processing, and total size annotations
• Corrects issues with total size annotations returning 0
• Filters out incomplete downloads for learners when learners are disallowed from creating download requests
• Updates NetworkLocation models to use location_type field instead of dynamic boolean and necessary migrations (planned in Reserved network locations for Studio and KDP #10431)
• Creates reserved NetworkLocation for Studio using UUID generated from CENTRAL_CONTENT_BASE_URL
• Updates NetworkLocation API to allow detail retrieval using instance_id assuming lack of conflicts, and excludes reserved locations in list responses
• Prevents strict comparison of instance_id and overwriting it for reserved NetworkLocations until we can get Studio to return the same instance ID
• Consolidates duplicate NetworkLocationResource APIs on the frontend
• Refactors existing canDownload allowing users to download resources externally, to disambiguate between new download feature
• Updates Learn useDevices composable to compare route and current device by instance_id
• Adds logging to catch() in learn's routing, and removes potentially duplicate calls to router.replace
• Integrates allow_learner_download_resources device setting in the frontend to only show the download button when enabled
• Upgrades le_utils from 0.1.38 to 0.2.1

References

learningequality/le-utils#111
Fixes #10732
Resolves #11022
Contributes to #10386
Starts #10431

Reviewer guidance

1. Requires you to manually run:

kolibri manage migrate discovery --database networklocation

2. In order to download from Studio, you need to change the setting in options.ini to the hotfixes server

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b1.dev0_git.96.gbccc9088.pex
Windows Installer (EXE)	kolibri-0.16.0b1.dev0+git.96.gbccc9088-unsigned.exe
Debian Package	kolibri_0.16.0b1.dev0+git.96.gbccc9088-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b1.dev0+git.96.gbccc9088-0.3.0.dmg
TAR file	kolibri-0.16.0b1.dev0+git.96.gbccc9088.tar.gz
WHL file	kolibri-0.16.0b1.dev0+git.96.gbccc9088-py2.py3-none-any.whl

[rtibbles]

Just a couple of questions - but nothing that should be blocking merge.

[rtibbles]

Is the error this is fixing specific to using the Exists subquery in a then statement?

[bjester]

I'm not sure. There seemed to be some mixing of parameter definitions and invocation styles with regards to single args and keyword args in the calls to resolve_expression. The function parameters are indeed all keyword args, but I recall seeing instances in other Django expressions where it was called with plain args, like this Case(then=) does here, but they happened to match the keyword arguments, which would still work right? The Exists wildcarded the keyword args, which seemed to cause the issue.

[rtibbles]

Code changes make sense, and manual testing checks out (weird local data issues aside!)