Skip to content

Make import metadata tests more robust for mptt fields. #11084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjester merged 1 commit into from
Aug 10, 2023
Merged

Make import metadata tests more robust for mptt fields. #11084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions kolibri/core/content/test/test_public_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from le_utils.constants import content_kinds
from rest_framework.test import APITestCase

from kolibri.core.content import base_models
from kolibri.core.content import models as content
from kolibri.core.content.constants.schema_versions import CONTENT_SCHEMA_VERSION
from kolibri.core.content.test.test_channel_upgrade import ChannelBuilder
Expand Down Expand Up @@ -40,11 +41,20 @@ def _assert_data(self, Model, queryset):
response = self.client.get(
reverse("kolibri:core:importmetadata-detail", kwargs={"pk": self.node.id})
)
fields = Model._meta.fields
BaseModel = getattr(base_models, Model.__name__, Model)
field_names = {field.column for field in BaseModel._meta.fields}
if hasattr(BaseModel, "_mptt_meta"):
field_names.add(BaseModel._mptt_meta.parent_attr)
field_names.add(BaseModel._mptt_meta.tree_id_attr)
field_names.add(BaseModel._mptt_meta.left_attr)
field_names.add(BaseModel._mptt_meta.right_attr)
field_names.add(BaseModel._mptt_meta.level_attr)
for response_data, obj in zip(response.data[Model._meta.db_table], queryset):
# Ensure that we are not returning any empty objects
self.assertNotEqual(response_data, {})
for field in Model._meta.fields:
if field.column in response_data:
for field in fields:
if field.column in field_names:
value = response_data[field.column]
if hasattr(field, "from_db_value"):
value = field.from_db_value(value, None, connection, None)
Expand Down