Skip to content

Conversation

@jredrejo
Copy link
Member

Summary

  • Refactors some kolibri code to extract ChannelBuilder to an standalone file

References

Relates: https://github.com/learningequality/kolibri-data-portal/issues/630

Reviewer guidance

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added the work-in-progress Not ready for review label Feb 12, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: medium labels Feb 12, 2024
@jredrejo jredrejo force-pushed the create_content_data branch from 75d684a to 69ad8d3 Compare February 12, 2024 20:07
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2024

@rtibbles rtibbles force-pushed the create_content_data branch from 69ad8d3 to 5e83665 Compare July 29, 2025 17:58
@rtibbles rtibbles marked this pull request as ready for review July 29, 2025 19:26
@rtibbles rtibbles changed the title [WIP] Helper to create content data for kolibri tests Helper to create content data for kolibri tests Jul 29, 2025
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a useful refactor by itself, and it's for test only code and tests still pass.

@rtibbles rtibbles removed the work-in-progress Not ready for review label Jul 29, 2025
@rtibbles rtibbles merged commit 4dfc73c into learningequality:develop Jul 29, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DEV: backend Python, databases, networking, filesystem... SIZE: large SIZE: medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants