Skip to content

Conversation

@AllanOXDi
Copy link
Member

Summary

This PR fixes unnecessary menu items displays along with the "Sync all facility data"

Before

Screen.Recording.2025-07-22.at.18.55.39.mov

After

Screen.Recording.2025-07-22.at.18.52.42.mov

References

#13476

Reviewer guidance

  1. Go to Device > Facilities and create and register at least 2 facilities to KDP
  2. Click the "Sync all" button

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend SIZE: very small labels Jul 22, 2025
@rtibbles
Copy link
Member

Is this a bug in KButtonGroup then that it interacts badly with KButtons that have drop downs?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

@AllanOXDi
Copy link
Member Author

AllanOXDi commented Jul 23, 2025

From my initial investigation - it seems like it.

Is this a bug in KButtonGroup then that it interacts badly with KButtons that have drop downs?

@AllanOXDi AllanOXDi changed the title Remove unnecessary menu items displays along with the "Sync all facility data" Remove unnecessary menu items displaying along with the "Sync all facility data" Jul 23, 2025
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AllanOXDi - LGTM!

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the smallest possible fix. @AllanOXDi can you file a follow up issue on KDS for the button group/dropdown menu interaction issue?

@rtibbles rtibbles changed the base branch from develop to release-v0.18.x July 23, 2025 14:41
@rtibbles rtibbles merged commit 66f2555 into learningequality:release-v0.18.x Jul 23, 2025
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend SIZE: very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants