-
Notifications
You must be signed in to change notification settings - Fork 866
[BUM] Add filters side panel #13608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUM] Add filters side panel #13608
Conversation
Build Artifacts
|
| member_of = ModelChoiceFilter( | ||
| method="filter_member_of", queryset=Collection.objects.all() | ||
| ) | ||
| related_to__in = ModelChoiceInFilter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im proposing adding a new filter related_to to check not just the membership of the user to a collection, but also if the user is assigned to that collection via user role. So when we filter by a class, we dont only get the students, but also the assigned coaches
| def filter_birth_year_gte(self, queryset, name, value): | ||
| queryset = queryset.exclude( | ||
| Q(birth_year__isnull=True) | ||
| | Q(birth_year=NOT_SPECIFIED) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if there is a better way to exclude the users that have these values in the filter
|
Hi @AlexVelezLl here's a list with minor issues observed while testing (as always these can be filed as follow-ups if out of scope for this PR):
all.filters.selected.mp4
filter.by.b.mp4
navigation.to.the.users.page.mp4 |
cadc7a6 to
2e5f031
Compare
|
Thanks @pcenov! I've just pushed some changes that should fix all your comments! :) @nucleogenesis @LianaHarris360 I am introducing the |
pcenov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @AlexVelezLl - all comments are addressed, LGTM!
|
@AlexVelezLl great call commonizing the usePreviousRoute composable - should be good to merge then |

Summary
facility/.../commonfolder.Screencast
Screencast.from.31-07-25.14.18.27.webm
References
Closes #13522.
Reviewer guidance
filtersbutton.