Skip to content

Add empty messages on classes lists #13785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexVelezLl merged 4 commits into from
Sep 30, 2025
Merged

Add empty messages on classes lists #13785

AlexVelezLl merged 4 commits into from
Sep 30, 2025

Conversation

@AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Sep 25, 2025

Summary

  • Add empty messages on side panels that containes a class list instead of displaying the empty SelectableList component.

Screenshoots

image image

References

Closes #13767

Reviewer guidance

  • Create a new facility without classes.
  • Create some users.
  • Try to filter/assign/enroll/remove these users from classes.

@github-actions github-actions bot added APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) DEV: frontend labels Sep 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.19.0b0.dev0_git.13.gb05b2e04.pex
Windows Installer (EXE) kolibri-0.19.0b0.dev0+git.13.gb05b2e04-windows-setup-unsigned.exe
Debian Package kolibri_0.19.0b0.dev0+git.13.gb05b2e04-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.19.0b0.dev0+git.13.gb05b2e04.dmg
Android Package (APK) kolibri-0.19.0b0.dev0+git.13.gb05b2e04-0.1.6-debug.apk
Raspberry Pi Image kolibri-pi-image-0.19.0b0.dev0+git.13.gb05b2e04.zip
TAR file kolibri-0.19.0b0.dev0+git.13.gb05b2e04.tar.gz
WHL file kolibri-0.19.0b0.dev0+git.13.gb05b2e04-py2.py3-none-any.whl

@AlexVelezLl AlexVelezLl mentioned this pull request Sep 26, 2025
Merged
@AlexVelezLl AlexVelezLl force-pushed the handle-empty-classes-list branch from 52b633e to 746b97a Compare September 29, 2025 16:05
LianaHarris360
LianaHarris360 reviewed Sep 29, 2025
View reviewed changes
Copy link
Member

@LianaHarris360 LianaHarris360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me, it just needs QA review!

@pcenov pcenov self-requested a review September 30, 2025 13:39
pcenov
pcenov approved these changes Sep 30, 2025
View reviewed changes
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlexVelezLl LGTM!

@AlexVelezLl
Copy link
Member Author

AlexVelezLl commented Sep 30, 2025

Thanks @pcenov!

@AlexVelezLl AlexVelezLl merged commit cbf5d7e into learningequality:develop Sep 30, 2025
51 checks passed
@AlexVelezLl AlexVelezLl mentioned this pull request Sep 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LianaHarris360 LianaHarris360 LianaHarris360 left review comments

@pcenov pcenov pcenov approved these changes

@nucleogenesis nucleogenesis Awaiting requested review from nucleogenesis

Assignees

No one assigned

Labels

APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) DEV: frontend SIZE: small

Projects

None yet

Milestone

Kolibri 0.19: Bulk User Management

Development

Successfully merging this pull request may close these issues.

[Bulk User Actions]: Better message when trying to unenroll users who are not enrolled anywhere

3 participants

@AlexVelezLl @LianaHarris360 @pcenov