[BUM Side Panel]: Fix hidden android side panels #13855
Conversation
…es mixin ensures the panel is fully visible, covering the android bottom bar in particular
github-actions
bot
added
APP: Facility
Build Artifacts
|
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
As per the conversation with Richard, it seems like this is the best solution! Just wonder if we should have done the same for the Lesson resource selection side panel? 😅. I think this is another consideration we can add to the discussion of the side panels for the KDS v6 project!
Just noting that in KDS we set the z-index to 24 for KModal (which in theory should be the same case as the side panel, since both of them are modals), which is consistent with our z-index design guidelines, just wondering if it would be worth it if we also set it to 24 here too? It won't make any difference as it is already working with 21 😅, but just for consistency!
|
@AlexVelezLl I always feel like I'm handling dangerous materials when I play with z-index so I made the smallest change I could that didn't break anything 😅 -- I wonder if having 24 on both would cause issues as there are cases where the KModal needs to show up above the side panel. |
|
That's a good point! We should update the design guidelines for this case, then, when there are two dialogs, one on top of the other. |
3 participants
Summary
Adds position:relative & z-index:21 to the bum-side-panel sass mixin.
References
Fixes #13784
Reviewer guidance
Aside from the bug in the related issue being fixed, please verify that the "Are you sure you will lose your changes" KModals work as expected as well (ie, they're properly visible on all screen sizes).