Skip to content

Conversation

@AllanOXDi
Copy link
Member

Summary

This PR fixes swallowing of error message on token modal
Closes#13794

References

#13794

Before

Screen.Recording.2025-09-29.at.11.28.11.AM.mov

After

Screen.Recording.2025-10-31.at.21.28.57.mov

Reviewer guidance

  1. Navigate to Device plugin > channels > Import studio
  2. Enter an incorrect token
  3. observe that the form field error only occurs when the field is active

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend SIZE: very small labels Oct 31, 2025
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix confirmed! Thanks @AllanOXDi !

@pcenov pcenov self-requested a review November 3, 2025 15:45
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AllanOXDi - LGTM!

@AllanOXDi AllanOXDi merged commit 71aba89 into learningequality:develop Nov 3, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend SIZE: very small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants