-
Notifications
You must be signed in to change notification settings - Fork 264
Closed
Labels
DEV: frontendP2 - normalPriority: Nice to havePriority: Nice to haveTAG: ux updategood first issueSelf-contained, straightforward, low-complexitySelf-contained, straightforward, low-complexityhelp wantedOpen source contributors welcomeOpen source contributors welcome
Description
🌱 Are you new to the codebase? Welcome! Please see the contributing guidelines.
Observed behavior
Some links that lead outside Studio don’t have a pop-out icon. One example is the “API documentation” link (leading to https://ricecooker.readthedocs.io/en/latest/index.html) in Settings → Account:
There are more links with this problem.
Expected behavior
Links that lead outside the Studio have a pop-out icon. For example, the aforementioned link needs to appear as:
This needs to be fixed for all links.
User-facing consequences
Visually distinguishing links leading to another website is widely recommended practice to minimize the surprise, and is an expected UX pattern in our products.
Guidance
- Revisit all places where
<KExternalLink>'s are used and ensure that all links that lead outside of Studio haveopenInNewTabset to truthy. Relatedly clean uptarget="_blank"since this is taken care of byopenInNewTab. - Note that not all
<KExternalLink>s are necessarily used for off-site navigation. Some of them are used to navigate between Studio sub-apps. Such links shouldn’t have truthyopenInNewTab(and therefore not open in a new tab and neither have a pop-out icon) since from the user’s point of view, they behave like internal links.
Metadata
Metadata
Assignees
Labels
DEV: frontendP2 - normalPriority: Nice to havePriority: Nice to haveTAG: ux updategood first issueSelf-contained, straightforward, low-complexitySelf-contained, straightforward, low-complexityhelp wantedOpen source contributors welcomeOpen source contributors welcome

