Ensure the saving and validation runs on bulk edit, even if user has not selected all nodes #4036
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Fixes #3910
This PR adds a
nextTickand setsselectedto the nodes available in the edit modal before proceeding with thehandleClosefunction, regardless of whether the user had selected all of them or not. Without having one or more nodes selected,DetailsTab.vueis not available, and therefore, accessing the saving functionality by reaching down through the child components to $refs.detailsTab is not possible. So, there is noimmediateSaveAlland nothing happens.[No Details Tab exists, since no items are checked]

This is admittedly a bit of a hacky workaround, and there is undoubtedly a better solution. However, beginning a refactor of the EditModal, even if narrowly scoped to rearrange some of this saving logic, feels risky to do so close to release.
I did consider some other solutions - such as moving the "Please select resources or folder to edit" into the details tab and rearranging some logic so the details tab would exist in this screen, but that seemed like a larger and potentially more complicated fix for not much more reward. I'd be happy to change my solution in that general direction or just try an entirely different approach, if there are some options I'm not considering.
Manual verification steps performed
Screenshots (if applicable)
saving-no-nodes.mp4
Does this introduce any tech-debt items?
It doesn't add any new tech debt, but it certainly doesn't help alleviate any
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)