Skip to content

Conversation

@marcellamaki
Copy link
Member

@marcellamaki marcellamaki commented Apr 20, 2023

Summary

Description of the change(s) you made

Fixes #3910

This PR adds a nextTick and sets selected to the nodes available in the edit modal before proceeding with the handleClose function, regardless of whether the user had selected all of them or not. Without having one or more nodes selected, DetailsTab.vue is not available, and therefore, accessing the saving functionality by reaching down through the child components to $refs.detailsTab is not possible. So, there is no immediateSaveAll and nothing happens.

[No Details Tab exists, since no items are checked]
Screenshot 2023-04-20 at 4 33 54 PM

This is admittedly a bit of a hacky workaround, and there is undoubtedly a better solution. However, beginning a refactor of the EditModal, even if narrowly scoped to rearrange some of this saving logic, feels risky to do so close to release.

I did consider some other solutions - such as moving the "Please select resources or folder to edit" into the details tab and rearranging some logic so the details tab would exist in this screen, but that seemed like a larger and potentially more complicated fix for not much more reward. I'd be happy to change my solution in that general direction or just try an entirely different approach, if there are some options I'm not considering.

Manual verification steps performed

  1. Unselect all items in the bulk edit view
  2. Click Finish - now, items should be saved and invalid items should be validated before proceeding
  3. Repeat the same process using the close (X) button

Screenshots (if applicable)

saving-no-nodes.mp4

Does this introduce any tech-debt items?

It doesn't add any new tech debt, but it certainly doesn't help alleviate any


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just works ™️! 💯

@bjester bjester merged commit 6dfeae9 into learningequality:unstable Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After file upload if no uploaded resource is selected, references to detailsTab will be undefined

2 participants