Updates for string freeze, pre-translation #4069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcellamaki
force-pushed
the
string-updates
branch
from
51ba003 to
1e27f83
Compare
radinamatic
approved these changes
May 10, 2023
Member
radinamatic
left a comment
radinamatic
left a comment
There was a problem hiding this comment.
Yey, much better strings now!!! 👏🏽 🥇 
bjester
reviewed
May 10, 2023
| context: | ||
| 'An error message displayed when some information required before publishing a channel is missing, for example when a resource has no license set.', | ||
| message: 'Required information is missing', | ||
| }); |
Member
There was a problem hiding this comment.
This whole translator is actually just wrong! It should have been:
export const validationStrings = createTranslator('ValidationStrings', {
msgId: {
message: 'Missing required information',
context:
'An error message displayed when some information required before publishing a channel is missing, for example when a resource has no license set.',
}
});but it isn't even used anywhere, so I'm deleting it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4068 and the items adjusted in the google doc after string review. Deletes 'context' which was extracted as a string in one case.