Skip to content

Conversation

@bjester
Copy link
Member

@bjester bjester commented Jun 6, 2023

Supersedes: #3733

Summary

Description of the change(s) you made

Adds logic that increments and decrements the total_count, resource_count, and coach_count when adding, updating, copying or moving nodes. The code processes change events, either caused by writes to indexedDB or changes from other users, and uses that information to update the ancestor node counts accordingly

Manual verification steps performed

  1. Create a new channel
  2. Add a folder Folder A, then a Folder B inside of that, and Folder C inside of B
  3. Upload a resource to Folder C
  4. Go back to the My Channels page
  5. Reopen the channel
  6. Observe the resource count on Folder A
  7. Duplicate the resource in Folder C
  8. Repeat steps 4-6
  9. Mark one of the resources in Folder C as coach content
  10. Repeat steps 4-6, but verify the coach count shows correctly
  11. Delete (move to trash) one of the resources in Folder C
  12. Repeat steps 4-6

Does this introduce any tech-debt items?

Deleting a node does not require any of this logic, since we move nodes to the trash tree before deleting them, but it does introduce some inconsistencies.


References

Fixes #3508
Fixes #2548

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester requested review from marcellamaki and rtibbles June 6, 2023 20:47
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me, and the Stream/Dispatcher pattern is very easy to follow and reason about.

Noticed one thing that we should open a follow up issue for, and one other question about a possible edge case, which we may also be able to punt on.

@bjester bjester force-pushed the take2-count-counts branch from 7a845c6 to fd90b26 Compare June 13, 2023 23:33
@rtibbles rtibbles merged commit fc2253b into learningequality:hotfixes Jun 16, 2023
@pcenov
Copy link
Member

pcenov commented Jun 20, 2023

Hi @bjester - no issues observed while manually testing this one. I did test various scenarios for this one and I can confirm that the resource count when adding, updating, copying or moving nodes is correct.

@bjester
Copy link
Member Author

bjester commented Jun 20, 2023

Woohoo! Great news @pcenov 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants