Skip to content

Conversation

@LianaHarris360
Copy link
Member

Summary

Description of the change(s) you made

This pr updates the breadcrumb item isFirst property and adds the isFirst property to VListTileTitle in Breadcrumbs.vue which fixes the incorrect folder order/layout for folders with long titles.

Screenshots (if applicable)

Before:
Screenshot 2023-06-19 at 9 08 38 AM

After:
Screenshot 2023-06-19 at 8 42 13 AM

Screenshot 2023-06-19 at 10 17 54 AM

Reviewer guidance

How can a reviewer test these changes?

  1. Open a channel with multiple nested folders
  2. Rename a folder so that it's name is longer than 50 characters
  3. Navigate to the nested folders and also try resizing the browser window size
  4. Confirm that only the first navigation item is the channel name and if the folder title is too long, it should be truncated

References

Fixes #4006

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@LianaHarris360 LianaHarris360 marked this pull request as ready for review June 19, 2023 15:41
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me! Thanks @LianaHarris360!

@LianaHarris360 LianaHarris360 merged commit f5f61b9 into learningequality:hotfixes Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants