Skip to content

Fix publish regression and prevent superfluous data export #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjester merged 2 commits into from
Jun 20, 2023
Merged

Fix publish regression and prevent superfluous data export #4158

bjester merged 2 commits into from
Jun 20, 2023

Conversation

@rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 20, 2023

Summary

Description of the change(s) you made

  • Removes all json.dumps that are now being written to JSONFields and so are unnecessary - updates tests accordingly
  • Prevents assessment metadata processing from editing data that is later written into the exported channel database by doing a deepcopy of the dict - updates tests accordingly

Manual verification steps performed

Just the automated tests.

@rtibbles rtibbles requested a review from bjester June 20, 2023 20:51
bjester
bjester approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjester bjester merged commit bcabc71 into learningequality:hotfixes Jun 20, 2023
@bjester bjester mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjester bjester bjester approved these changes

Assignees

No one assigned

Labels

TODO: needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rtibbles @bjester