Prevent source edits for copied/imported resources #4189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjester
requested changes
Jul 6, 2023
Member
bjester
left a comment
bjester
left a comment
There was a problem hiding this comment.
The fixes definitely prevent editing, but I think more can be done to visually clarify their readonly state. Right now they don't look any different. This is actually the reason I mentioned disabled. Perhaps we want both?
Member
Author
|
Both seem to work as expected. It just seems overkill for me as a think |
Member
Author
|
|
'#'=0 '$'=7983 '*'=( ) -=569JNRXghikls '?'=127 @=( ) ARGC=0 EPOCHREALTIME EPOCHSECONDS HISTCMD=5996 LINENO=24 PPID=76126 TTYIDLE=0 ZSH_EVAL_CONTEXT=toplevel:cmdsubst ZSH_SUBSHELL=1 builtins dis_builtins dis_functions_source dis_patchars dis_reswords epochtime funcfiletrace funcsourcetrace funcstack functions_source functrace history historywords jobdirs jobstates jobtexts modules parameters patchars reswords status=127 terminfo userdirs usergroups zsh_eval_context=( toplevel cmdsubst )
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
This pr Prevent "Source" fields edits for copied/imported resources. Also please see this comment for context on fix made
Manual verification steps performed
Please see issues #3111 and #4090.
Does this introduce any tech-debt items?
No
Reviewer guidance
How can a reviewer test these changes?
References
Fixes #3111 and #4090
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)