Skip to content

Conversation

@cerdo03
Copy link
Contributor

@cerdo03 cerdo03 commented Dec 17, 2023

Summary

Description of the change(s) you made

Fixes #2008
I have replaced all occurences of BottomToolBar with Bottombar. Modified the import statements accordingly.


Reviewer guidance

How can a reviewer test these changes?

References

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@cerdo03 cerdo03 changed the title removed bottomToolBar Removed BottomToolBar with BottomBar Dec 17, 2023
</VFlex>
</VLayout>
<BottomToolBar
<BottomBar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! @cerdo03. We need to be careful because the implementation of BottomToolBar and BottomBar are slightly different, for example BottomBar does not recieve any props, but BottomToolBar does. So all places where BottomToolBar receives props are likely to have errors. I let you an example for the CalatogList component:

Before the change:
image

After the change:
image

The views should remain the same after the change to avoid unintended behaviours.

<slot></slot>
</VContainer>
<BottomToolBar v-if="$slots.bottom" color="white" flat clipped-left clipped-right>
<BottomBar v-if="$slots.bottom" color="white" flat clipped-left clipped-right>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we also have a different view:

Before:
image

image

After:
image

image

@AlexVelezLl
Copy link
Member

Hi! @cerdo03 Hope you are doing fine. Just a friendly reminder that this PR is still open, do you plan to continue working on it? Or we can close it and assign the issue to someone else?

@AlexVelezLl
Copy link
Member

Closing due to inactivity

@AlexVelezLl AlexVelezLl closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate bottom bar components

3 participants