Skip to content

Conversation

@akolson
Copy link
Member

@akolson akolson commented Apr 18, 2024

Summary

Description of the change(s) you made

This pr updates studio to use the new LE logo

Manual verification steps performed

  1. Log into Studio
  2. Click on the Content Creation tab.

Screenshots (if applicable)

Before
image

After
image

Does this introduce any tech-debt items?

NA


Reviewer guidance

How can a reviewer test these changes?

  1. Log into Studio
  2. Click on the Content Creation tab.

References

Fixes #4521

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me the dimensions on the image tags aren't quite correct to the aspect ratio of the original image. It's possible VImg maintains the correct aspect ratio regardless, but would be good for it to match for clarity if we define both width and height (sometimes defining both is unnecessary)

The new logo's inherit dimensions are 456px by 305px.

Having a target height H: W = 456 / 305 * H
Having a target width W: H = 305 / 456 * W

@akolson
Copy link
Member Author

akolson commented Apr 22, 2024

Sure, Blaine! Let me try this and revert.

@bjester bjester self-assigned this Apr 22, 2024
@akolson akolson requested a review from bjester April 23, 2024 20:36
@akolson
Copy link
Member Author

akolson commented Apr 23, 2024

@bjester, I think we should be good now with the dimensions.

@akolson akolson marked this pull request as ready for review April 23, 2024 20:37
@bjester
Copy link
Member

bjester commented Apr 23, 2024

I'm not sure why, and I don't see anything in your changes that should cause this, but it seems the logo isn't rendering in generated PDFs for multiple channels. My only idea is whether there's something wonky in the SVG markup itself.

Hotfixes Your PR
Screenshot from 2024-04-23 16-00-12 Screenshot from 2024-04-23 15-48-35

@bjester
Copy link
Member

bjester commented Apr 23, 2024

I tried adding the following to the head of the SVG and it still didn't work. I also validated the SVG markup 🤷

<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN" "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">

Screenshot from 2024-04-23 16-12-40

Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve! @marcellamaki would you double check?
image

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks @akolson and @bjester!

@marcellamaki marcellamaki merged commit 2c021fe into learningequality:hotfixes Apr 24, 2024
@akolson akolson mentioned this pull request Apr 29, 2024
@akolson akolson deleted the update-le-logo branch October 31, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants