Post-rebranding update to Card hover styling#4549
Post-rebranding update to Card hover styling#4549bjester merged 3 commits intolearningequality:hotfixesfrom
Conversation
|
Looks great @bjester! Just a couple of questions about whether this change should also be applied to the 'Helpful Resources for Covid-19' card at the top of the Content Library and also whether the hover effect is not good enough when selecting channels for a collection. See the following video: 2024-05-14_16-47-09.mp4 |
Yeah the global updates I made somehow missed the COVID card at the top of search. We should make it consistent. As for the collection cards, they were initially flat which posed a problem considering we don't really have flat-hovered card style. At the very least, the cards' bottom shouldn't be clipped by the card below. That said, we should probably switch to a regular card, but as it's coded right now, the checkbox needs to be removed from the card itself, which is a bit out of scope of the rebranding changes. So I lean towards fixing the current cosmetic issues and followup later with proper update for the collection UI. We can probably accomplish revamping the collection cards when we integrate KCard, to avoid unnecessary dev. |
Summary
Description of the change(s) you made
VCardhover styling with howKCardhover styling will be implementedVCards containing buttons.scssfile handling alongside existinglessandstylhandling for JestManual verification steps performed
Screenshots (if applicable)
Previous
Updated
Does this introduce any tech-debt items?
Not necessarily. When we replace
VCardwithKCard, hopefully there will be little to no visual differencesReviewer guidance
How can a reviewer test these changes?
See my testing steps
Are there any risky areas that deserve extra testing?
Clicking buttons on cards, ensuring that the default card action does not get triggered and the button's specific action is triggered instead.
References
Fixes #4547
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)