Update publish logic with edge case

[akolson]

Summary

Description of the change(s) you made

This PR enhances the remote publish logic to safeguard against accidental overwrites of the changes and published statuses in IndexedDB, particularly in scenarios where multiple users are editing the same resource. It ensures that one user's publish action does not inadvertently overwrite another user's unpublished changes.

Manual verification steps performed

1. Log in to Studio using two separate user sessions (e.g., one in incognito mode and the other in a normal browser).
2. Make changes to the same content in both user sessions.
3. Publish the changes in one session.
4. In the other session, monitor the syncing changes. To test this thoroughly, you can throttle the browsers connection to offline mode and then restore it to confirm that changes remain intact before and after connectivity is restored.
5. Inspect the CONTENTNODE and CHANGES_TABLE in IndexedDB to verify that the syncing has no effect on changes.

Does this introduce any tech-debt items?

---

Reviewer guidance

How can a reviewer test these changes?

• See manual verification steps above

References

Fixes #4138

Comments

---

Contributor's Checklist

PR process:

• If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
• If this includes an internal dependency change, a link to the diff is provided
• The docs label has been added if this introduces a change that needs to be updated in the user docs?
• If any Python requirements have changed, the updated requirements.txt files also included in this PR
• Opportunities for using Google Analytics here are noted
• Migrations are safe for a large db

Studio-specifc:

• All user-facing strings are translated properly
• The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
• All UI components are LTR and RTL compliant
• Views are organized into pages, components, and layouts directories as described in the docs
• Users' storage used is recalculated properly on any changes to main tree files
• If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

• Code is clean and well-commented
• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Any new interactions have been added to the QA Sheet
• Critical and brittle code paths are covered by unit tests

---

Reviewer's Checklist

This section is for reviewers to fill out.

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[rtibbles]

It didn't occur to me before, but couldn't we just add an additional where condition here so this becomes:

.where({ table: TABLE_NAMES.CONTENTNODE, key: node.id })
.limit(1)
.toArray();

return unpublishedNodeIds.length === 0;

[akolson]

Oh yeah more cleaner!

[akolson]

@rtibbles, we should be good now, I think?

[rtibbles]

I think so!

[rtibbles]

Code looks good, will do a quick manual test locally to confirm.

[rtibbles]

I think so!

[rtibbles]

The manual test checks out, this is good to go! Beautiful stuff.