Skip to content

Fix duplicate nodes #4661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rtibbles merged 1 commit into from
Aug 20, 2024
+6 −1
Merged

Fix duplicate nodes #4661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion contentcuration/contentcuration/frontend/shared/data/resources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1426,7 +1426,12 @@ export const ContentNode = new TreeResource({
return Promise.all([getNode, this.where({ parent: parent.id }, false)]).then(
([node, siblings]) => {
let lft = 1;
siblings = siblings.filter(s => s.id !== id);
// if isCreate is true and target === id, it means it is inserting a node after the
// same node (duplicating it), so we will need this node among the siblings to get
// the right sort order
if (!isCreate || target !== id) {
siblings = siblings.filter(s => s.id !== id);
}
if (siblings.length) {
// If we're creating, we don't need to worry about passing the ID
lft = this.getNewSortOrder(isCreate ? null : id, target, position, siblings);
Expand Down