Skip to content

Conversation

@marcellamaki
Copy link
Member

No description provided.

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are consistent with what we agreed upon during the review 👍🏽

Are these all the changes needed? I have a nagging feeling that there was something else pending... 🤔

@marcellamaki marcellamaki marked this pull request as ready for review August 27, 2024 19:50
@marcellamaki marcellamaki force-pushed the update-strings-for-bulk-editing-release branch from 4b5251d to 0d18170 Compare August 29, 2024 17:12
@marcellamaki marcellamaki force-pushed the update-strings-for-bulk-editing-release branch from 0d18170 to e07fcef Compare August 29, 2024 17:51
@marcellamaki marcellamaki merged commit 507fa32 into learningequality:unstable Aug 29, 2024
@radinamatic
Copy link
Member

There are still a few strings on unstable that do not align with edits for consistency that we agreed on during the UX writing review. I marked the cells of the pending ones with the yellow background in our working document.

@radinamatic radinamatic mentioned this pull request Aug 29, 2024
@radinamatic
Copy link
Member

Final manual QA on the unstable branch confirms the fix.

@akolson akolson mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants