-
Notifications
You must be signed in to change notification settings - Fork 264
Undo the reverted changes in #4714 #4737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo the reverted changes in #4714 #4737
Conversation
d53b86d to
35dcb4a
Compare
AlexVelezLl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @AllanOXDi! I just made some notes. Also noted that we still need to bring back the rest of the original PR, as we have only add the original changes in the EditBooleanMapModal file, but the changes in the rest of files are missing. You can check them here https://github.com/learningequality/studio/pull/4714/files.
...ation/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
Outdated
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
Outdated
Show resolved
Hide resolved
140c15f to
5d24098
Compare
| if (value.includes(node.id)) { | ||
| const currentNode = this.getContentNode(node.id); | ||
| if (this.hasMixedCategories) { | ||
| Object.assign(fieldValue, currentNode[this.field] || {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the comments here for future references.
// If we have mixed categories remain the old ones, and
// just add new categories if there are any
...ation/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
Outdated
Show resolved
Hide resolved
e8881c3 to
5f998c1
Compare
...ation/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelEdit/components/QuickEditModal/EditBooleanMapModal.vue
Show resolved
Hide resolved
c240deb to
55432b4
Compare
AlexVelezLl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AllanOXDi! Looks good to me!
Summary
This pull request addresses the issue where the text 'This field is required' is displayed when bulk editing learning activities.
Fixes #4651
Reviewer guidance
How can a reviewer test these changes?
References
#4651
Summary
This pull request addresses the issue where the text 'This field is required' is displayed when bulk editing learning activities.
Fixes #4651
Reviewer guidance
How can a reviewer test these changes?
References
#4651
Comments
Contributor's Checklist
PR process:
CHANGELOGlabel been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocslabel has been added if this introduces a change that needs to be updated in the user docs?requirements.txtfiles also included in this PRStudio-specifc:
notranslateclass been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages,components, andlayoutsdirectories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarnandpip)