Skip to content

Approve vue-demi postinstall build #5070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bjester merged 1 commit into from
May 20, 2025
Merged

Approve vue-demi postinstall build #5070

bjester merged 1 commit into from
May 20, 2025

Conversation

@bjester
Copy link
Member

@bjester bjester commented May 20, 2025

Summary

@bjester had missed approving a build in the pnpm migration. This PR approves it


╭ Warning ───────────────────────────────────────────────────────────────────────────────────╮
│                                                                                            │
│   Ignored build scripts: vue-demi.                                                         │
│   Run "pnpm approve-builds" to pick which dependencies should be allowed to run scripts.   │
│                                                                                            │
╰────────────────────────────────────────────────────────────────────────────────────────────╯

@bjester bjester requested review from akolson and ozer550 May 20, 2025 17:23
akolson
akolson approved these changes May 20, 2025
View reviewed changes
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @bjester

@bjester bjester merged commit 70a2f99 into learningequality:unstable May 20, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akolson akolson akolson approved these changes

@ozer550 ozer550 Awaiting requested review from ozer550

Assignees

@akolson akolson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bjester @akolson