Skip to content

Conversation

@vtushar06
Copy link
Contributor

Summary

This PR replaces Vuetify components with Kolibri Design System components in the ‘Page not found’ error page, specifically:
• Replaced AppError with StudioAppError (created in issue #5235)
• Replaced VBtn with KRouterLink using appearance="raised-button" and primary props

Manual verification performed:
• Temporarily modified ChannelListIndex.vue to force display PAGE_NOT_FOUND error
• Tested error page rendering, button functionality, and mobile responsiveness
• Verified RTL compliance

Screenshots:
After changes-
pageNotFound

References

Closes: #5296
• Parent issue: #5060

Reviewer guidance

To test these changes:
1. Temporarily modify ChannelListIndex.vue condition to: v-if="true" and :error="{ errorType: 'PAGE_NOT_FOUND' }"
2. Login with user@a.com / a
3. Navigate to Channels page
5. Test mobile view and RTL
6. Remember to revert testing changes in ChannelListIndex.vue

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense, manual QA checks out. Thank you for your contribution!

@rtibbles rtibbles merged commit 45e09cd into learningequality:unstable Aug 22, 2025
14 checks passed
@vtushar06
Copy link
Contributor Author

@rtibbles you're Welcome looking forward for more opportunities.

AllanOXDi pushed a commit to AllanOXDi/studio that referenced this pull request Nov 20, 2025
* fix/page-not-found

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] 'Page not found' error page in Channels

2 participants