-
Notifications
You must be signed in to change notification settings - Fork 287
Fixes the KLogo display in preview window #5351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the KLogo display in preview window #5351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @akolson -- overall I think this looks good and seems to be working, but one thing I noticed is that for me at least, the loading state doesn't seem to resolve with PDFs specifically (I also tested video, audio file, epub, and html zip). I just have a perpetual animated Kolibri loader. I have a vague recollection that there might be something weird about PDF event emissions -- maybe @AlexVelezLl remembers more or has some ideas. Not sure if it could be related to that, or something more straightforward?
ETA - if showing a thumbnail or something doesn't work, or seems like it would be an out of scope fix for some reason i'm not remembering, i think a palceholder thumbnail is fine. it's just the fact that the animated loading state makes it feel like the user is "still waiting", which i think is not an ideal experience, because it's confusing
|
Hmm Im being able to see PDFs @marcellamaki 🤔, could it be an specific type of PDF? |
AlexVelezLl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good to me!
|
Possibly! @AlexVelezLl could you share with me on slack a sample PDF that is working for you and I can test it, and then we can see if it works for me or not, and likewise i can try a couple of other PDFs i have and see if they work, or if i'm encoutering the same problem? |
|
@marcellamaki feel free to share with me any failing pdfs via slackso I can take a closer look once you arrive at a conclusion. Thanks |
|
I tried the PDF that @AlexVelezLl sent me, as well as a few other PDFs, just in case it was a file issue, and I'm still seeing the same thing, unfortunately. (not just the display, but you can see the loading state is still
If I manually change the value to false via vue dev tools, I see this: Is that what both of you are seeing? |
marcellamaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some discussion with @akolson and him and alex both being able to have PDFs work without issue, we'll merge this to hotfixes and confirm there, and then follow up or revert as needed.
|
Previewing of recommended resources seems to have an issue as experienced by @marcellamaki . Will make the fix in another pr that references #5327 Screen.Recording.2025-09-04.at.10.27.55.AM.mov |


Summary
This pr fixes the
KLogodisplay in the resource preview window during loading of resourcesBefore
search.recommendations.kolibri.logo.mp4
After

References
Fixes #5327
Reviewer guidance