Skip to content

Conversation

@akolson
Copy link
Member

@akolson akolson commented Sep 2, 2025

Summary

This pr fixes the KLogo display in the resource preview window during loading of resources

Before

search.recommendations.kolibri.logo.mp4

After
Screenshot 2025-09-02 at 15 59 50

References

Fixes #5327

Reviewer guidance

  • Sign in to Hotfixes with an account with enabled search recommendations
  • Go to a channel with resources and try to preview a resource
  • Attempt to import a resource from other channels and preview it

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @akolson -- overall I think this looks good and seems to be working, but one thing I noticed is that for me at least, the loading state doesn't seem to resolve with PDFs specifically (I also tested video, audio file, epub, and html zip). I just have a perpetual animated Kolibri loader. I have a vague recollection that there might be something weird about PDF event emissions -- maybe @AlexVelezLl remembers more or has some ideas. Not sure if it could be related to that, or something more straightforward?

ETA - if showing a thumbnail or something doesn't work, or seems like it would be an out of scope fix for some reason i'm not remembering, i think a palceholder thumbnail is fine. it's just the fact that the animated loading state makes it feel like the user is "still waiting", which i think is not an ideal experience, because it's confusing

@AlexVelezLl
Copy link
Member

Hmm Im being able to see PDFs @marcellamaki 🤔, could it be an specific type of PDF?

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me!

@marcellamaki
Copy link
Member

Possibly! @AlexVelezLl could you share with me on slack a sample PDF that is working for you and I can test it, and then we can see if it works for me or not, and likewise i can try a couple of other PDFs i have and see if they work, or if i'm encoutering the same problem?

@akolson
Copy link
Member Author

akolson commented Sep 3, 2025

@marcellamaki feel free to share with me any failing pdfs via slackso I can take a closer look once you arrive at a conclusion. Thanks

@marcellamaki
Copy link
Member

marcellamaki commented Sep 4, 2025

I tried the PDF that @AlexVelezLl sent me, as well as a few other PDFs, just in case it was a file issue, and I'm still seeing the same thing, unfortunately. (not just the display, but you can see the loading state is still true). The alignment and everything looks fine!

Screenshot 2025-09-04 at 9 25 56 AM

If I manually change the value to false via vue dev tools, I see this:
Screenshot 2025-09-04 at 9 30 39 AM

Is that what both of you are seeing?

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussion with @akolson and him and alex both being able to have PDFs work without issue, we'll merge this to hotfixes and confirm there, and then follow up or revert as needed.

@akolson akolson merged commit e3ce243 into learningequality:hotfixes Sep 4, 2025
14 checks passed
@akolson
Copy link
Member Author

akolson commented Sep 4, 2025

Previewing of recommended resources seems to have an issue as experienced by @marcellamaki . Will make the fix in another pr that references #5327

Screen.Recording.2025-09-04.at.10.27.55.AM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants