-
Notifications
You must be signed in to change notification settings - Fork 287
[Remove Vuetify from Studio] Buttons in Move modal #5355 #5409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remove Vuetify from Studio] Buttons in Move modal #5355 #5409
Conversation
MisRob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Prashant-thakur77, code changes make sense and I confirm button interactions still work as expected.
I noticed one problem on smaller screens, where "Add new folder" button label is cut off:
This will likely be caused by the surrounding context rather than button itself, nevertheless it's a regression compared to the previous experience so it will need to be fixed before we merge. Can you investigate what's the cause?
|
Hello @MisRob, I looked into the button truncation issue and found two key reasons:
Solution: |
|
Perfect @Prashant-thakur77, please proceed. Thanks for clarity around what's going on. |
…om/Prashant-thakur77/studio into replace-vuetify-buttons-move-modal
|
Hello @MisRob, I've submitted the PR for the MoveModal button truncation fix.Please let me know if there's anything else I can contribute to! |
MisRob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Prashant-thakur77.
All looks well - haven't observed any regressions in functionality, breadcrumbs, or buttons.
Please let me know if there's anything else I can contribute to!
We're happy to have you contribute to this project - I'm opening new issues regularly - find them in the usual way via the link in the contributing guidelines. Thanks a lot.

Fixes #5355
Summary
Updated Buttons from Vbtn to KButton in Move modal
Used KButtonGroup for the bottom right Buttons for 8px spacing.
IMAGES

References
• Parent issue: #5060
Reviewer guidance
Login as a@a.com with password a
Go to Channels > Published Channel
Check topic or resource
Click "Move" icon