Skip to content

Conversation

@Prashant-thakur77
Copy link
Contributor

Fixes #5355

Summary

Updated Buttons from Vbtn to KButton in Move modal
Used KButtonGroup for the bottom right Buttons for 8px spacing.

IMAGES
Screenshot From 2025-09-29 00-07-59

References

• Parent issue: #5060

Reviewer guidance

Login as a@a.com with password a
Go to Channels > Published Channel
Check topic or resource
Click "Move" icon

@MisRob MisRob self-requested a review September 29, 2025 04:40
@MisRob MisRob self-assigned this Sep 29, 2025
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Prashant-thakur77, code changes make sense and I confirm button interactions still work as expected.

I noticed one problem on smaller screens, where "Add new folder" button label is cut off:

button-bug

This will likely be caused by the surrounding context rather than button itself, nevertheless it's a regression compared to the previous experience so it will need to be fixed before we merge. Can you investigate what's the cause?

@Prashant-thakur77
Copy link
Contributor Author

Hello @MisRob,

I looked into the button truncation issue and found two key reasons:
Reference for Kbutton properties https://github.com/learningequality/kolibri-design-system/blob/develop/lib/buttons-and-links/buttons.scss

  1. Flex Property Differences:
    =>VBtn has ( flex: 0 0 auto )with flex-shrink: 0 which prevents shrinking
    =>KButton has no explicit flex properties, defaulting to flex-shrink: 1 (aggressive shrinking)

  2. Breadcrumbs Constraint:
    The Breadcrumbs component uses max-width: calc(100% - 86px) which leaves only 86px for the button. Combined with KButton's max-width: 100%, this causes truncation.

Solution:
The solution is just to add a class to the Kbutton and assign flex-shrink=0 to it.

This is after using the solution mentioned above.
image

@MisRob
Copy link
Member

MisRob commented Sep 29, 2025

Perfect @Prashant-thakur77, please proceed. Thanks for clarity around what's going on.

@Prashant-thakur77
Copy link
Contributor Author

Prashant-thakur77 commented Sep 29, 2025

Hello @MisRob,

I've submitted the PR for the MoveModal button truncation fix.Please let me know if there's anything else I can contribute to!
Thanks for your guidance! 💫.

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Prashant-thakur77.

All looks well - haven't observed any regressions in functionality, breadcrumbs, or buttons.

Please let me know if there's anything else I can contribute to!

We're happy to have you contribute to this project - I'm opening new issues regularly - find them in the usual way via the link in the contributing guidelines. Thanks a lot.

@MisRob MisRob merged commit eea9a89 into learningequality:unstable Sep 30, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Remove Vuetify from Studio] Buttons in Move modal

2 participants