Fix focus ring on some buttons + confirmation dialogs not appearing for channel sharing operations #5483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisRob
force-pushed
the
button-fixes
branch
3 times, most recently
from
2c17d7a to
c528ed0
Compare
MisRob
changed the title
(1) Remove general button style override to allow KDS focus ring logic to take effect (2) Update VBtn style override to be consistent with the KDS focus ring style
for channel sharing operations. Clicking 'Delete invitation', 'Grant edit permissions', and 'Revoke view permission' did nothing. The problem may be related to stacking order of Vuetify-based confirmation dialogs. Fixed by migrating to KDS components. Also removes internal implementation dependencies from the related test suite and migrates it to Vue Testing Library.
Member
Author
|
Related issue #5406 (comment) |
Member
Author
|
Thanks @akolson. I confirmed with @marcellamaki that this can go to hotfixes to merging now. |
Member
|
Keyboard navigation and confirmation modals work/appear as expected, and all options have a nice visual focus outline 👏🏽 🎉
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For example, this one (+ 2 more):
See commit messages for details.
Reviewer guidance
Preview few buttons
Edit a channel
Go to Sharing tab
Test all four channel sharing operations that can be accessed from the Options dropdown