-
Notifications
You must be signed in to change notification settings - Fork 287
[Remove Vuetify from Studio] Channel collection options #5492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remove Vuetify from Studio] Channel collection options #5492
Conversation
…ents with KButton and KModal for improved consistency and functionality
|
Hi @MisRob, I'm seeing test failures in Could you please help me out.Thanks |
|
Thank you @vtushar06 - we will assign a reviewer within next two weeks. As for the failing test, this is what I see here in GitHub and it suggests it's related to your changes - can you try to examine them locally one more time?
I haven't examined your code - just general note on dialog-related tests - this note may help. |
…t DOM triggers for better clarity and maintainability
MisRob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @vtushar06 - code changes make sense and everything works as expected. Just one note on unit testing.
...ation/contentcuration/frontend/channelList/views/ChannelSet/__tests__/channelSetItem.spec.js
Outdated
Show resolved
Hide resolved
…oved readability and maintainability
…pull changes form remote
|
Hi @MisRob! |
MisRob
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @vtushar06. Just few last tweaks and then we can merge.
As for the failing checks, yes those are not related to your changes. I will check on it.
contentcuration/contentcuration/frontend/channelList/views/ChannelSet/ChannelSetItem.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelList/views/ChannelSet/ChannelSetItem.vue
Outdated
Show resolved
Hide resolved
...ation/contentcuration/frontend/channelList/views/ChannelSet/__tests__/channelSetItem.spec.js
Outdated
Show resolved
Hide resolved
…e test to return router from renderComponent
|
Hi @MisRob, could you please take a look at the recent changes and let me know if everything looks good or if any adjustments are needed? |
|
Thank you @vtushar06 - all is good. |

Summary
Replaced Vuetify components with Kolibri Design System (KDS) components in Channel collection options:
Manual verification:
✅ Options dropdown opens below the button with Edit and Delete options (with icons)
✅ Delete confirmation modal displays correctly with proper text alignment
✅ All buttons and modals function as expected
✅ Tested in both LTR and RTL modes
Screenshots:
…
References
closes: #5484
…
Reviewer guidance
…