Use MathML for math formatting#155
Conversation
|
I like it! For few second, I was hesitant because the previous syntax was closer to code. But, we are talking math, so the visual make sense. If you can upload it somewhere, I can test on my iDevice and check if render similar. Thanks! |
ulysses4ever
left a comment
There was a problem hiding this comment.
Great contribution, thanks!
Small comments inline.
This branch is now live at matthijsblom.github.io/learnyouahaskell.github.io. Need I fear that the changed build script (to be reverted before merge) on this branch will cause spurious builds in this repo? We don't want this branch served at learnyouahaskell.github.io. |
|
Off-topic: We really should implement automatic PR preview. But last time I looked at it recently, is a bit of a pain in the neck to set up. |
All good on my iDevice. Thank you! |
|
If you can revert the github action change, remove the draft then I will approve. Thank you! |
ulysses4ever
left a comment
There was a problem hiding this comment.
LGTM modulo the workflow edits to deploy locally
|
I think I've covered the whole book now. I don't think the I'll rebase to improve the commit messages and remove the CI change after incorporating the final feedback. ( By the way: I've been doing a pass through the whole book. If you're curious, see my |
|
I'm fine with $'s for single identifiers. I resolved all my comments from earlier, so to my mind this is ready to go. |
For now this is only a proof of concept.
If this direction is appreciated, I might look into it further.
To Do: