Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
This pull request aims to introduce a new method,
plain3, which employs a newline (\n) as the starting symbol for 3-digit addition baseline tests. Below are the summarized results comparingplain3against the baselineplainmethod.Summary of Results
For
plain3: The best accuracy achieved was 95.8%(Full data is available under identifier:
plain3_results)For baseline
plain: The best accuracy achieved was 86.9%(Full data is available under identifier:
baseline_plain_results)As seen, the
plain3method outperforms the baseline in terms of test accuracy. However, it still falls short of achieving a 97% accuracy rate.Conclusion
The introduction of the
plain3method offers an improvement over the baselineplainmethod in terms of test accuracy. Further analysis is needed to understand the remaining gap from a 97% accuracy rate.Your review and feedback on this pull request would be highly appreciated.
appendix
plain3_resultswith the commandpython train.py config2/addition/plain/train_addition_bal.py \ --ckpt_path_name="ckpt_10000.pt" \ --out_dir="out/addition_plain3/$model_root" \ --data_type='text' --data_format='plain3' \ --dataset='bal' --train_data_path="train_3digit_10000.txt" \ --eval_addition=True --start='FILE:data/bal/test_10000.txt' \ --wandb_log=False \ --exp_name="$model_root"baseline_plain_resultswith the commandpython train.py config2/addition/plain/train_addition_bal.py \ --ckpt_path_name="ckpt_10000.pt" \ --out_dir="out/addition_plain/$model_root" \ --data_type='text' --data_format='plain' \ --dataset='bal' --train_data_path="train_3digit_10000.txt" \ --eval_addition=True --start='FILE:data/bal/test_10000.txt' \ --wandb_log=False \ --exp_name="$model_root"