Restore asymmetric padding in DownSampleBlock::forward#1132
Closed
wwoodsTM wants to merge 1 commit intoleejet:masterfrom
Closed
Restore asymmetric padding in DownSampleBlock::forward#1132wwoodsTM wants to merge 1 commit intoleejet:masterfrom
wwoodsTM wants to merge 1 commit intoleejet:masterfrom
Conversation
…rward while keeping circular padding support
Contributor
|
I can't say if this is the right fix for inpainting, but at least #1128 (another image size related bug) still happens with this change. |
Owner
|
Thanks, but I think #1133 would be a better fix. |
Author
Agreed, I just tried the newest commit with this fix and it also resolves the bug. Idk if my little PR was even helpful at the end of the day lol, especially if this was already a known issue, but it was nice to learn a bit about the code base either way. Thanks to anybody who took a look or tested! |
Author
|
Closing this since it was resolved by #1133 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that after commit 50ff966 that I was getting 8-pixel borders added to the top and left of all my inpainting outputs (with images of any dimensions). I experimented with different fixes until I found this one key line in DownSampleBlock::forward (
common.hpp) that seems to be contributing to the 2x2x2 (8 px) offset / borders that I was seeing. I also attempted to keep circular padding in there while maintaining the original behavior overall.Now whether this is the ideal fix for all use cases I am not 100% sure, but I am hoping someone with more expertise can see if this is a valid fix as it has been working well so far.
Thank you.