refactor: simplify f8_e5m2_to_f16 function a little bit#1358
Merged
leejet merged 1 commit intoleejet:masterfrom Mar 29, 2026
Merged
refactor: simplify f8_e5m2_to_f16 function a little bit#1358leejet merged 1 commit intoleejet:masterfrom
leejet merged 1 commit intoleejet:masterfrom
Conversation
SkutteOleg
pushed a commit
to SkutteOleg/stable-diffusion.cpp
that referenced
this pull request
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has be bothering me for a while. The f8_e5m2_to_f16() function is needlessly over-engineered.