Resolved issue serializing deleted keys to the server after call to Clear()#29
Open
devmonkey22 wants to merge 1 commit intoleewang0:masterfrom
Open
Resolved issue serializing deleted keys to the server after call to Clear()#29devmonkey22 wants to merge 1 commit intoleewang0:masterfrom
devmonkey22 wants to merge 1 commit intoleewang0:masterfrom
Conversation
…is as deleted to handle when Clear() is called, which clears all SerializedRawData immediately, so then keys never really get deleted at the server.
Contributor
Author
|
@welegan Can you confirm if this satisfies your intent between the logic in RedisSessionStateItemCollection.Clear() which also clears the SerializedRawData collection too; and the RedisSessionStateItemCollection.GetChangedObjectsEnumerator() called during RedisSessionStateStoreProvider.SerializeToRedis ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regardless of if SerializedRawData found and removed the key, mark the key as deleted to handle when Clear() is called, which clears all SerializedRawData immediately, so then keys never really get deleted at the server.