Overhaul of internals to support masked chars and multi-line code quotes in raw mode#44
Draft
jmonroynieto wants to merge 3 commits intolemnos:masterfrom
Draft
Overhaul of internals to support masked chars and multi-line code quotes in raw mode#44jmonroynieto wants to merge 3 commits intolemnos:masterfrom
jmonroynieto wants to merge 3 commits intolemnos:masterfrom
Conversation
The aim of this change is to support code typing texts using the quote function. This commit changes the previous rendering workflow to one that only runs changes in the necesary words when there is a render-worthy event. Now the screen uses cells extensively which have been extended to contain format metadata. The tracking is changed to a new set of strings in the evaluatio where "typed" is compared to "rubric" but rendering and cursor placement are based on "text" which can contain masked characters. 99% of functionality works fine. Styling and backspace in masked characters in raw mode is still wonky. Further details in PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #42 and #11
The aim of this change is to support code-typing texts using the quote function.
This commit changes the previous rendering workflow to one that only runs changes in the necessary words when there is a render-worthy event. Now the screen uses cells extensively which have been extended to contain format metadata. This simplifies styling since each cell knows what it should look like in any given state.
The comparison scheme is changed to a new set of strings in the evaluation where "typed" is compared to "rubric" but rendering and cursor placement are based on "text" which may contain masking characters.
An additional color option for masking characters that represent whitespace was necessary. The program now finds a suitable option derived from the theme.
Some of the changes aim to improve readability and update deprecated dependencies.
99% of functionality works fine. Styling and backspace in masked characters in raw mode are still wonky in some cases. See
debugConfigbranch in my fork to check out the tests that I was running for this.