Migrate to loguru #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This configuration pushes all logger logs to loguru, and defines our loguru configuration.
Loguru's retention setting only cleans up 'old' files, IE files that have been rotated. With this config, once a log file reaches 10MB it will be rotated out and a new log file will be used. Those 'old' files are then cleaned up 7 days after they were created.
lemonsaurus
approved these changes
Oct 21, 2021
Owner
lemonsaurus
left a comment
lemonsaurus
left a comment
There was a problem hiding this comment.
yeah, this looks good and right to me. Let's do it. 🐰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes#14
This adds loguru to the project, migrates all current logging calls to loguru, and sets up a forward so that any libs that use the std lib logger get pushed to loguru.
TODO - Look into retention & rotation in loguru