Remove type circularity in wizard.tsx #4480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code has a type circularity that previously went undetected. Adding an `as Wizard` assertion here removes the circularity. See microsoft/TypeScript#46939 / microsoft/TypeScript#46981
RyanCavanaugh
requested review from
Nokel81 and
jweak
and removed request for
a team
Contributor
|
Thank you! |
Author
|
I'm not really set up to do that; this is mostly an FYI. I'll close and whoever does the TS 4.6 upgrade can refer back to the fix. Thanks! |
Collaborator
|
Thanks for the heads up anyhow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has a type circularity that previously went undetected. Adding an
as Wizardassertion here removes the circularity.See microsoft/TypeScript#46939 / microsoft/TypeScript#46981 for more context