Fix lints and typechecking errors #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
towerofnix
approved these changes
Jul 16, 2024
Member
towerofnix
left a comment
towerofnix
left a comment
There was a problem hiding this comment.
Thanks! Looks good except for the one question, and we opened #208 to follow this up with CI.
|
|
||
| protected _costumeNumber: number; | ||
| protected _layerOrder: number; | ||
| public _layerOrder: number; |
Member
There was a problem hiding this comment.
Is there any way we could avoid making this underscore-public? I guess you just added a similar TODO above for _project, but it sounds like we should also avoid it for _layerOrder.
Collaborator
Author
There was a problem hiding this comment.
I've added a TODO for removing _layerOrder entirely--we should just store sprites in-order as Scratch does.
Member
There was a problem hiding this comment.
Can we file that as an issue too LOL. Otherwise, again, awesome. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these seem to be from the "if on edge, bounce" PR.
In the future, we should consider setting up some CI for pull requests that lints and typechecks them automatically.