Skip to content

Linter formatter #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rajitha1998 merged 4 commits into from
Jun 19, 2022
Merged

Linter formatter #117

rajitha1998 merged 4 commits into from
Jun 19, 2022

Conversation

@pranjalwalia
Copy link
Contributor

@pranjalwalia pranjalwalia commented Apr 15, 2022

Fixes #116

Proposed Changes

  • addded eslint and prettier configuration files in root nodecloud workspace
  • added extended eslint config for the generator workspace to remove linter errors to allow for initialization of eslint, but should be tightened in future after discussion with project maintainers
  • added prettier config to avoid conflicting code syntax
  • added linter workflow to husky precommit, run the already existing linter script in workspace generator

@pranjalwalia
chore: initialize prettier config file
976dc71 
- add prettier config + ignore file
- pending: add eslint with plugins for typescript and configure script formatter for prettier
@pranjalwalia
chore: setup initial eslint root workspace config
17c7571 
- add root workspace eslint config
- pending: setup eslint configs for packages
@pranjalwalia
eslint: plugin for imports + code gen moduke conf
6996c7f 
- updated eslint config for workspace generator so that existing code
does not throw errors, but scope for code standardization is apparent.

- currently the codebase does not employ and standardization in
import/export rules and they are all over the place currently

- adding this eslint plugin will enforce import/export guidelines in
combination with prettier and ensures all imports are standardized
across the codebase
@pranjalwalia
chore: fixed linter errors in generator
bc6166a 
- fixed all linter errors produced by new eslint config

- pending 140 linter warnings (large change) that can be fixed post approval from
project mentors
@rajitha1998 rajitha1998 self-requested a review June 11, 2022 03:40
rajitha1998
rajitha1998 approved these changes Jun 19, 2022
View reviewed changes
Copy link
Member

@rajitha1998 rajitha1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rajitha1998 rajitha1998 requested a review from mbcse June 19, 2022 15:53
mbcse
mbcse approved these changes Jun 19, 2022
View reviewed changes
Copy link
Collaborator

@mbcse mbcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@rajitha1998 rajitha1998 merged commit c859719 into leopardslab:master Jun 19, 2022
@pranjalwalia pranjalwalia mentioned this pull request Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajitha1998 rajitha1998 rajitha1998 approved these changes

@mbcse mbcse mbcse approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TOOLING] Addition of ESLint and prettier configuration

3 participants

@pranjalwalia @rajitha1998 @mbcse