Cannot Update Navigation menu items at Runtime

[RohitM-IN]

Describe the bug

I am trying to add few Items based on configuration after the user logs in but the issue is I can see that the item is been added to the navigation menu but for some reason its not shown in the layout.

I can tell that the property is being changed but its not updating in the UI.

It works fine if I add the NavigationViewItem at constructor but not when i use a Command or for starters using the default events like for example NavigationView_PaneOpened

        private void NavigationView_PaneOpened(NavigationView sender, RoutedEventArgs args)
        {
            if (_isPaneOpenedOrClosedFromCode)
                return;

            NavigationView.MenuItems.Clear();
            NavigationView.MenuItems.Add(new NavigationViewItem("SamplePage", SymbolRegular.Home24, typeof(SamplePage)));

            _isUserClosedPane = false;
        }

To Reproduce

Try adding a NavigationViewItem after page load like in event or Relay Command ,etc

here is old data

I can see that the item is added in navigation item

after clearing the list and adding new items:

but its not appearing in the main window navigation

Expected behavior

The NavigationViewItem Should be added in Navigation menu items list

Screenshots

No response

OS version

Windows 10

.NET version

.net 7

WPF-UI NuGet version

using the git development branch's dll with commit 438edf8

Additional context

No response

[Seeker1437]

I found a workaround:

THe best way to get it to update is manually setting MenuItems each time.

You'll want to force a new allocation to get the immediate update effect (or at least I did for me)

aka x.MenuItems = SomeListOfMenuItems.ToList();

The issue with MenuItemsSource is that it is not properly set up to trigger all the effects because it doesn't properly listen to changes in the source collection. Setting the list seems to make it do everything it needs to at the time including showing that it can be expanding/collapsed.

EDIT: This might only be true for 3.0.0.preview1 oops

EDIT: Confirmed this workaround is still needed on faed583

[happygb21-jc]

May I ask when this problem can be resolved? Or how to solve it temporarily? thanks

[Seeker1437]

Try the one above...

[happygb21-jc]

用于 3.0.0.preview1 oops

After trying, it still doesn't work

[Seeker1437]

Oops my apologies I have neglected to mention you'd basically avoid using MenuItemsSource directly for this workaround to work correctly, you'd only ever set MenuItems all the time.

[happygb21-jc]

设置

Thanks, But the result is the same, still unable to update the interface

[Seeker1437]

I realize I didn't really given enough information.

I am essentially manually setting and updating the list and then setting the list on the NavigationItem Directly.

The original lost source in my case is an ObservableCollection. I deep listen to it's event (add, remove, modified) and manually modify an intermediate collection of what the MenuItems are supposed to be before actually setting the list to the menu item that needs it.

Once I am at my computer I will update this response with what I am doing. Maybe I missed a detail which may help you understand and reproduce my results.

[Seeker1437]

https://gist.github.com/Seeker1437/c383564715af7653b150cd6d11b93f0a forgive me! I forgot D:

[scanfing]

item didn't show because of Template is null,
when NavigationView ItemTemplate Changed, NavigationView
will call UpdateMenuItemsTemplate() to set NavigationViewItem's Template.

and

Wpf.Ui.Controls.NavigationView source code NavigationView.Navigation.cs line: 175 - 213 - 219

if (SelectedItem != NavigationStack[0] && NavigationStack[0].IsMenuElement)
{
SelectedItem = NavigationStack[0];
OnSelectionChanged();
}

try :

NavigationView.MenuItems.Add(new NavigationViewItem("SamplePage", SymbolRegular.Home24, typeof(SamplePage)){ Template = NavigationView.ItemTemplate, IsMenuElement =true });