Fix NavigationView pane not closed by default when using IsPaneOpen="False"

[tmijail]

Pull request type

Please check the type of change your PR introduces:

• Update
• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes

What is the current behavior?

Setting IsPaneOpen="False" on a NavigationView is ignored.

Issue Number: #741

What is the new behavior?

When IsPaneOpen="False", the pane starts collapsed.

Other information

[koal44]

There's a bug:

System.Windows.Media.Animation.AnimationException:
'Cannot animate the 'Width' property on a 'System.Windows.Controls.Grid' using a 'System.Windows.Media.Animation.DoubleAnimation'.
InvalidOperationException:
'System.Windows.Media.Animation.DoubleAnimation' cannot use default destination value of 'NaN'.

To reproduce, open the Gallery App and head over to the Navigations Page.

The problem was introduced when you ran UpdateVisualState method for every NavigationView control when it's loaded, although i think the problem is a bit more tricky.

I'll try to help narrow down what's going on.

In the GalleryApp, NavigationViewPage.xaml, we use a <ui:NavigationView PaneDisplayMode="LeftFluent"/>.
In Wpf.Ui, styling for NavigationView.xaml we have

<Style.Triggers>
    <Trigger Property="PaneDisplayMode" Value="Left">
        <Setter Property="ItemTemplate" Value="{StaticResource LeftCompactNavigationViewItemTemplate}" />
    </Trigger>
    <Trigger Property="PaneDisplayMode" Value="LeftFluent">
        <Setter Property="OpenPaneLength" Value="NaN" />
    </Trigger>
</Style.Triggers>

and in NavigationViewCompact.xaml (LeftCompactNavigationViewItemTemplate), we have animations that run visual state changes <DoubleAnimation To="{TemplateBinding OpenPaneLength}" />

Even though the template for Left doesn't apply for LeftFluent the TemplateBinding will update to NaN and cause problems.

[tmijail]

@koal44 You're right. I didn't check the other display modes. Really sorry about that.

I sent a fix in PR #1015.