Update UiApplication.cs#1082
Merged
pomianowski merged 3 commits intolepoco:developmentfrom May 12, 2024
Merged
Conversation
Ignore `Application` without LibraryResources
pomianowski
approved these changes
May 12, 2024
Contributor
Author
|
@pomianowski |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore
Applicationwithout Library ResourcesPull request type
Please check the type of change your PR introduces:
What is the current behavior?
If the
Application.Currentdoes not contain anyWpf.Ui;resource that application still is used , this PR checks the resources and ignore theApplicationthat does not useWpf.Ui;.Issue Number: #1081
What is the new behavior?
By default nothing gonna change: if the
MyApp\App.xamlhave resources related to theWpf.Uilibrary theApplication.Currentis used like before.This PR only impact when the library is running outside of the desktop app context.
Other information